Output leading zeros on numbers as seen in input (Fixes #550) #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| n->position(), | ||
| n->value(), | ||
| n->unit(), | ||
| true); |
There was a problem hiding this comment.
Should this be n->zero() rather than hardcoded to true?
There was a problem hiding this comment.
Nope, it should be that way, as ruby sass outputs it with a leading zero if it is comming from a variable (even in you've written it without). This is exactly what makes libsass behave the same way and the spec tests include this one!
|
Keep this bool flag in the AST node makes sense. I don't see any reason to modify the C API for this. I took a run at this last week but eventually got caught on #549. |
mgreter
added a commit
that referenced
this pull request
Nov 6, 2014
Output leading zeros on numbers as seen in input (Fixes #550)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #550 and some other related issues!
To do this I had to add a status bool to
Numberto preserve the state that we have parsed!Turned out to be trickier than anticipated, but it should now be in line with ruby sass!
I initially implemented that status flag on all number representations down to the C interface, but decided to drop it for now as it would mean a small change in the API and I added this a local branch for now.