Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Commit

Permalink
feat: Node 20 support (#3355)
Browse files Browse the repository at this point in the history
* feat: Node 20 support

* ci: update stalled Alpine/Linux jobs

* feat: drop Node 14
  • Loading branch information
nschonni authored May 20, 2023
1 parent 06ae4c7 commit 87f3899
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 23 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/alpine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ jobs:
fail-fast: false
matrix:
node:
- 14
# Node 16+ are perma-red for the tests right now
# - 16
# - 18
# - 19
- 16
- 18
- 19
- 20

steps:
- name: Install Alpine build tools
Expand Down
15 changes: 5 additions & 10 deletions .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,11 @@ jobs:
strategy:
fail-fast: false
matrix:
node:
- 14
- 16
- 18

include:
- node: 14
gcc: "gcc-6"
gpp: "g++-6"
os: ubuntu-18.04
- node: 16
gcc: "gcc-8"
gpp: "g++-8"
os: ubuntu-18.04
os: ubuntu-20.04
- node: 18
gcc: "gcc-8"
gpp: "g++-8"
Expand All @@ -35,6 +26,10 @@ jobs:
gcc: "gcc-8"
gpp: "g++-8"
os: ubuntu-20.04
- node: 20
gcc: "gcc-10"
gpp: "g++-10"
os: ubuntu-22.04


steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
fail-fast: false
matrix:
node:
- 14
- 16
- 18
- 19
- 20

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
fail-fast: false
matrix:
node:
- 14
- 16
- 18
- 19
- 20

architecture:
- x64
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ Below is a quick guide for minimum and maximum supported versions of node-sass:

NodeJS | Supported node-sass version | Node Module
--------|-----------------------------|------------
Node 20 | 9.0+ | 115
Node 19 | 8.0+ | 111
Node 18 | 8.0+ | 108
Node 17 | 7.0+, <8.0 | 102
Node 16 | 6.0+ | 93
Node 15 | 5.0+, <7.0 | 88
Node 14 | 4.14+ | 83
Node 14 | 4.14+, <9.0 | 83
Node 13 | 4.13+, <5.0 | 79
Node 12 | 4.12+, <8.0 | 72
Node 11 | 4.10+, <5.0 | 67
Expand Down
6 changes: 3 additions & 3 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@
environment:
SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
matrix:
- nodejs_version: 14
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
- nodejs_version: 16
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
Expand All @@ -45,6 +42,9 @@
- nodejs_version: 19
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
- nodejs_version: 20
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019


install:
Expand Down
1 change: 1 addition & 0 deletions lib/extensions.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ function getHumanNodeVersion(abi) {
case 102: return 'Node.js 17.x';
case 108: return 'Node.js 18.x';
case 111: return 'Node.js 19.x';
case 115: return 'Node.js 20.x';
default: return false;
}
}
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "node-sass",
"version": "8.0.0",
"version": "9.0.0",
"libsass": "3.5.5",
"description": "Wrapper around libsass",
"license": "MIT",
Expand All @@ -16,7 +16,7 @@
"url": "http://andrew.github.com"
},
"engines": {
"node": ">=14"
"node": ">=16"
},
"main": "lib/index.js",
"nodeSassConfig": {
Expand Down

1 comment on commit 87f3899

@Autoserg

This comment was marked as off-topic.

Please # to comment.