This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
The compiled binary should be also cached. #1882
Labels
Comments
I don't understand. If the binary fails to download how can we cache the downloaded binary? |
Sorry, I mean that we should cache the compiled binary as well. If downloading failed --> Compile binary from source. The compiled binary should be also cached, so that if we delete the |
Maybe just add a addition step after compile binary from source: copy compiled binary to |
|
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Feb 22, 2017
Currently the binary download is streamed to disk once a 200 response has been recieved. When an error occurs during the download a partially downloaded binary is left on disk. Subsequent installs see the binary and bail out of re-downloading it. Worse yet those subsequent installs move the binary into the global cache so even removing node_modules will not remove the broken binary. With this patch the binary is only flushed to disk once it has been fully downloaded. Fixes sass#1882 Fixes sass#1888
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Feb 22, 2017
Currently the binary download is streamed to disk once a 200 response has been recieved. When an error occurs during the download a partially downloaded binary is left on disk. Subsequent installs see the binary and bail out of re-downloading it. Worse yet those subsequent installs move the binary into the global cache so even removing node_modules will not remove the broken binary. With this patch the binary is only flushed to disk once it has been fully downloaded. Fixes sass#1882 Fixes sass#1888
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this issue
Mar 10, 2018
Currently the binary download is streamed to disk once a 200 response has been recieved. When an error occurs during the download a partially downloaded binary is left on disk. Subsequent installs see the binary and bail out of re-downloading it. Worse yet those subsequent installs move the binary into the global cache so even removing node_modules will not remove the broken binary. With this patch the binary is only flushed to disk once it has been fully downloaded. Fixes sass#1882 Fixes sass#1888
xzyfer
added a commit
that referenced
this issue
Mar 10, 2018
Currently the binary download is streamed to disk once a 200 response has been recieved. When an error occurs during the download a partially downloaded binary is left on disk. Subsequent installs see the binary and bail out of re-downloading it. Worse yet those subsequent installs move the binary into the global cache so even removing node_modules will not remove the broken binary. With this patch the binary is only flushed to disk once it has been fully downloaded. Fixes #1882 Fixes #1888
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
npm -v
): 4.1.2node -v
): v6.9.5node -p process.versions
):node -p process.platform
): linuxnode -p process.arch
): x64node -p "require('node-sass').info"
):npm ls node-sass
):I find the compiled binary not be cached in
~/.npm/node-sass
. So If thenode-modules/
dir removed will download or compile again.If the downloading pre-compiled binary failed(
4.5.0
), and the compiled binary not be cached in~/.npm/node-sass/
. I think it's better to cache the compiled binary as well.The text was updated successfully, but these errors were encountered: