Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Feature: Implement Custom Headers Support #822

Closed
am11 opened this issue Mar 30, 2015 · 3 comments
Closed

Feature: Implement Custom Headers Support #822

am11 opened this issue Mar 30, 2015 · 3 comments

Comments

@am11
Copy link
Contributor

am11 commented Mar 30, 2015

Corresponds to sass/libsass#1000.

//cc @jhnns

@am11
Copy link
Contributor Author

am11 commented Apr 2, 2015

@xzyfer, just saw the rest of the conversation at sass/libsass#1000, I have changed the milestone. Based on whether or not libsass is going to continue with this feature (via RFC), we will hold off the implementation and continue supporting importer. Would you please open an RFC in libsass tracker so everyone can share thoughts on these features? It is really interesting feature, but violation of the core precepts of language design (as mentioned by @chriseppstein), I agree that it should not be continued.

(I think it would still possible to provision such functionality via custom plugin, but that can probably co-exit)

@xzyfer
Copy link
Contributor

xzyfer commented Apr 2, 2015

Apologies for being vague.

I'm waiting for @mgreter to chime in. I agree that multiple importers is a
great feature.

I think having both features lumped into a single PR has unintentionally
conflated to two features. For that reason I think the RFC is important for
these features to be fully understood.
On 2 Apr 2015 21:37, "Adeel Mujahid" notifications@github.com wrote:

@xzyfer https://github.com/xzyfer, just saw the rest of the
conversation at sass/libsass#1000
sass/libsass#1000, I have changed the
milestone. Based on whether or not libsass is going to continue with this
feature (via RFC), we will hold off the implementation and continue
supporting importer. Would you please open an RFC in libsass tracker so
everyone can share thoughts on these features? It is really interesting
feature, but violation of the core precepts of language design (as
mentioned by @chriseppstein https://github.com/chriseppstein), I agree
that it should not be continued.

(I think it would still possible to provision such functionality via
custom plugin, but that can probably co-exit)


Reply to this email directly or view it on GitHub
#822 (comment).

@xzyfer
Copy link
Contributor

xzyfer commented Mar 26, 2016

Close this as custom headers is not ready for general use and isn't a LibSass priority until after 4.0.

@xzyfer xzyfer closed this as completed Mar 26, 2016
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this issue Apr 7, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants