Output directory is created if it doesn't exists.

[SebastianOsuna]

Pull Request for #574 .

Changes are on 'output-directory' branch.

:)

[am11]

Lets don't add extra linefeeds. Between consecutive blocks one blank line is enough.

[am11]

LGTM 👍

Thanks @SebastianOsuna! ⚡

[SebastianOsuna]

@am11 No problem. I hope it helps.

Do you need me to change the line you commented?

[am11]

Yes and rebase. That would nice! :)

[kevva]

-1. Just replace fs with fs-extra and use the fs.outputFile() function instead of fs.writeFile().

[am11]

I don't think we need extra dependency (which further depends on three more dependencies) for a little chore like this.

[kevva]

Well, this needs some rewriting then. Code looks horrible. For instance, we don't need to check if the folder exists or not, mkdirp takes care of that.

[kevva]

Functions are written using camelCase like function writeOut() and not using var. But we don't need this function anyway.

[am11]

@SebastianOsuna, we are readying for vNext, could you make those changes and rebase soon?

[SebastianOsuna]

Fixes done. I'm not sure if the rebase was successful, I'm not an expert with git yet, sorry.

[am11]

@SebastianOsuna,

git pull --rebase
git rebase -i HEAD~5

# the editor will open
# change the word 'pick' to 'f', for each
# uncommented line *after* the one with text:
# "Output directory is created if it doesn't exists. "
# save and close the editor

# now forcefully rewrite the history:
git push -f

That's it! :)

[SebastianOsuna]

Rebase done with the commands provided. Sorry for the delay.

[am11]

@SebastianOsuna, the outcome should be one commit. But right now you have 8 commits.

So lets try this:

git remote add node-sass https://github.com/sass/node-sass
git pull --rebase node-sass master
git push -f

This will clean those other commits your PR is showing.

Then we will rebase in interactive mode (later, once you rebase against node-sass master).

[SebastianOsuna]

Ok, did that but still 2 commits and both duplicated :(

[am11]

That's ok. Now you can run: git rebase -i HEAD~4. And then in editor, except for the first line, change pick to f for the next three lines, save and close the editor. Finally, git push -f, to rewrite the history.

[SebastianOsuna]

Sorry, but I can't seem to make it work. Each time I try the fixup, the log doesn't change. I even tried with the squash option, but no success.

[am11]

If you are on Windows, you would probably get a notepad opened after you do git rebase -i HEAD~4 with the following:

pick 099e501 Output directory is created if it doesn't exists.
pick b180fb5 Output directory is created if it doesn't exists.  
pick c2d56dc Code styling fixes.
pick 91f2012 Code styling fixes.

Change it to:

pick 099e501 Output directory is created if it doesn't exists.
f b180fb5 Output directory is created if it doesn't exists.  
f c2d56dc Code styling fixes.
f 91f2012 Code styling fixes.

Ctrl+S and close notepad. Finally run git push -f.

Does this work?

[SebastianOsuna]

Was closing vim with the wrong command, sorry.

[am11]

Perfect. Thanks for your patience and contribution! 👍