This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Build related fixes #609
Merged
Build related fixes #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
force-pushed
the
master
branch
2 times, most recently
from
61ceea2 to
3dae5be
Compare
am11
force-pushed
the
master
branch
3 times, most recently
from
7815296 to
9968f3e
Compare
|
|
||
| function validateProxyUrl(url) { | ||
| if (/\n/.test(url)) { | ||
| url = url.replace(/\r?\n+/, '\n').split('\n')[8]; |
There was a problem hiding this comment.
Because you're doing proxy.output.trim() before passing into validateProxyUrl I believe this needs to be [5] not [8]. I would just this be make it more resilient.
url = url.replace(/\r?\n+/, '\n').split('\n');
url = url[url.length - 3].trim(); // get the second last element.There was a problem hiding this comment.
The resilient approach looks promising. I rebased it: am11@6539e7b.
Thanks! 😸
* Uses different strategy to test binary. * Test two cases and declare the binary OK. Issue URL: sass#611.
1 task
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
install newly required header in autotools build system
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install: Improves code to get proxy.
Build: Use grep to filter test cases.
Issue URL: v2 release checklist #611.