-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
am11
commented
Feb 10, 2015
- Build: Use node-gyp from dependencies.
- Code: Minor refactoring.
- CI: Tests io.js runtime.
- Promotes node.js to v1.2.
- Test: Adds outFile related tests.
- Test: Adds sourceMap path related tests.
98162cd
to
5a31a68
Compare
Coverage!!! ⚡ |
@am11 keep going!! 100%%% coverage or go home |
Can you give some context to what you mean by
|
Code: Minor refactoring.
* Promotes node.js to v1.2.
@xzyfer, for example I used to run
With this change, all you need to do is to run |
io.js is failing because it is building binary with io.js runtime but Also something has changed in io.js v1.1 (and perhaps corresponding libuv), due to which it is failing some tests locally as well. (was passing all with io.js v1.0.x though). Nonetheless, we can build io.js 1.1 binaries for node-sass 2.0.0 with pangyp (node scripts/build). 😎 |
@austinpray that is the plan! :) Just gained a bit more with this diff: - try {
- err = JSON.parse(err);
- } catch (e) {
- err = { message: err };
- }
-
+ err = JSON.parse(err); Note that I removed try-catch because we don't need defensive programming. It is an "interface promise" by LibSass API that the errors shall be returned in JSON format. If there is an anomaly then the bug belongs to LibSass. 🪲 |
Thanks for the clarification @am11. The global node-gyp caught me out recently as well. This is much better. |
47dcb7d
to
c1d2ffe
Compare
69e9156
to
b48d5d6
Compare