This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Improve install script #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var proxyUrl; | ||
|
|
||
| if (!er) { | ||
| ['https-proxy', 'proxy', 'http-proxy'].some(function(setting) { |
There was a problem hiding this comment.
FWIW this could be reduced to
var proxyUrl = ['https-proxy', 'proxy', 'http-proxy'].filter(function(setting) {
return conf.get(setting);
})[0];There was a problem hiding this comment.
Or even simpler yet?
var env = process.env;
options.proxy = conf.get('https-proxy') || conf.get('proxy') || conf.get('http-proxy') ||
env.HTTPS_PROXY || env.https_proxy || env.HTTP_PROXY || env.http_proxy;
|
Thanks for your contribution. 👍 My hands are full with this binary patch thingy to confirm the changes. @xzyfer, can you please take a look if this safe to merge at this point? |
|
LGTM. Waiting on CI. |
|
🎉 |
1 task
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to solve an error. When there are some kind of errors downloading the binary file (network errors mostly) the file where it was going to be downloaded to is not unlinked and left as an empty file and then the build script "thinks" that the download went ok and does not do the manual build. I changed the code to create the file just when it is necessary.