This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Misc. Fixes #668
Merged
Misc. Fixes #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reason: njs v0.11 is not relavent any more.
* Solution: Update to node v0.12 with which
node-sass v2.0.1 is compatible OOTB.
|
Good stuff lately @am11! This look good to me. |
|
Thanks for the feedback @kevva. :) |
am11
force-pushed
the
master
branch
10 times, most recently
from
0a38ada to
168d78f
Compare
am11
force-pushed
the
master
branch
16 times, most recently
from
f8d6cf2 to
15f9c22
Compare
* Returns json-string error from LibSass as is. * Extends empty error object with parsed JSON. Note: The reason why NanError is not used because LibSass returns error as JSON string with message as member, so we would have to reparse and reassign the obj in that case. Issue URL: sass#675. PR URL: sass#668.
am11
added a commit
to am11/node-sass
that referenced
this pull request
Feb 15, 2015
On Windows, process.execPath does not get resolved symlink path. This commit fixes the issue. Related Issue: nodejs/node#851. PR URL: sass#668.
am11
added a commit
to am11/node-sass
that referenced
this pull request
Feb 15, 2015
On Windows, process.execPath does not get resolved symlink path. This commit fixes the issue. Related Issue: nodejs/node#851. PR URL: sass#668.
am11
added a commit
to am11/node-sass
that referenced
this pull request
Feb 15, 2015
On Windows, process.execPath does not get resolved symlink path. This commit fixes the issue. Related Issue: nodejs/node#851. PR URL: sass#668.
On Windows, process.execPath does not get resolved symlink path. This commit fixes the issue. Related Issue: nodejs/node#851. PR URL: sass#668.
|
@xzyfer, PTAL. Note: It does not fix the AppVeyor issue with iojs v1.2 because they are not redirecting node --> iojs when iojs is an active runtime, but they are instead having a concrete node.exe with v1.2 which possesses wrong proc info. Probably they will fix it with the way nvmw handle it: appveyor/ci#139 (comment). Otherwise, we will have to induce that cmd via appveyor.yaml (while deleting node.exe from iojs directory). |
|
Nothing jumps out at me 👍 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-sass v2.0.1 is compatible OOTB.
Errorobject.Note: The reason why
NanErroris not usedbecause LibSass returns error as JSON
string with
messageas member, so we wouldhave to reparse and reassign the obj in that case.
Issue URL: Error should be an actual
Error#675.On Windows, process.execPath does not
get resolved symlink path. This commit
fixes the issue.
Related Issue: Windows: execPath is not assigned resolved symbolic link nodejs/node#851.