Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Rework test coverage facility w/ istanbul #910

Merged
merged 2 commits into from
Aug 20, 2015
Merged

Rework test coverage facility w/ istanbul #910

merged 2 commits into from
Aug 20, 2015

Conversation

saper
Copy link
Member

@saper saper commented Apr 29, 2015

  1. Use istanbul instead of jscoverage
  2. generate nice HTML report with branches
  3. include 'spec.js' tests in the coverage reporting - hits/line ratio on index.js ~300
  4. show little coverage summary in the console output
  5. do not use spawn and shell to launch mocha and coveralls clients - wire reporters directly via JavaScript

@saper saper mentioned this pull request Apr 29, 2015
Closed
@saper saper changed the title 1) Use istanbul instead of jscoverage 2) generate nice HTML report with branches 3) include 'spec.js' tests in the coverage reporting - hits/line ratio on index.js ~300 4) show little coverage summary in the console output 5) do not use spawn and shell to launch mocha and coveralls clients - wire reporters directly via JavaScript Rework test coverage facility w/ istanbul Apr 29, 2015
@xzyfer xzyfer added this to the 3.next milestone Apr 29, 2015
@saper
Use istanbul for test coverage
1263983 
If there is no coverage at all we get
an empty global variable and the lcov
empty file may cause coveralls failure.

Use mkdirp() to create lib-cov
@saper saper force-pushed the istanbul04 branch 2 times, most recently from 433cde6 to 54b5316 Compare August 8, 2015 02:00
@saper
Copy link
Member Author

saper commented Aug 8, 2015

Well, it looks like travis-ci now testing with io.js 3.0.0 as the "latest".

@saper
Copy link
Member Author

saper commented Aug 19, 2015

@xzyfer @am11 what do you think about this? I like not having to invoke shell to do coverage testing (although the resulting JS file is not the simplest).

@saper saper force-pushed the istanbul04 branch 2 times, most recently from 8acde28 to e2a20e5 Compare August 19, 2015 17:17
@saper
Measure coverage for api, runtime and spec js tests
3caabeb 
Instrument spec.js for test coverage
measurement.
am11
am11 reviewed Aug 19, 2015
View reviewed changes
package.json
@@ -64,7 +64,7 @@
"devDependencies": {
"coveralls": "^2.11.2",
"cross-spawn": "^1.0.3",
"jscoverage": "^0.5.9",
"istanbul": "^0.3.13",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: latest version is 0.3.18.

@am11
Copy link
Contributor

am11 commented Aug 19, 2015

LGTM. Lets see if CI agrees. :)

Well, it looks like travis-ci now testing with io.js 3.0.0 as the "latest".

As per docs, seems like we need to change this line: https://github.com/sass/node-sass/blob/f95af4/appveyor.yml#L12 to - nodejs_version: 3 in order to have same affect in AppVeyor.

@xzyfer
Copy link
Contributor

xzyfer commented Aug 19, 2015

I'm fine with this.

@saper saper merged commit 3caabeb into sass:master Aug 20, 2015
am11 referenced this pull request Aug 21, 2015
@xzyfer
Be explicit about which runtime versions travis should test
24801f4
@xzyfer xzyfer modified the milestones: next.minor, v3.3.0 Aug 26, 2015
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
@mgreter
Merge pull request sass#910 from mgreter/feature/output-emitter
8e74f7f 
Refactor output emitter and implement missing output styles
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees

@saper saper

Labels
Dev - Reviewed Feature - Implementation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@saper @am11 @xzyfer