Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

JRuby Compatibility #113

Merged
merged 1 commit into from
Dec 17, 2018
Merged

JRuby Compatibility #113

merged 1 commit into from
Dec 17, 2018

Conversation

glebm
Copy link
Contributor

@glebm glebm commented Nov 17, 2018

@glebm
JRuby Compatibility
dae1bb5 
1. Test on JRuby.
2. Fix sass#92.
@deivid-rodriguez
Copy link

Tried this PR against activeadmin in activeadmin/activeadmin#5504 and it got it green!

Thanks so much for the work you've been doing on sassc-rails and libsass, @glebm!

@glebm
Copy link
Contributor Author

glebm commented Dec 8, 2018

Any reason this hasn't been merged yet? Anything I can help with?

@bolandrm bolandrm merged commit 594afce into sass:master Dec 17, 2018
@glebm glebm deleted the jruby branch December 17, 2018 14:24
@deivid-rodriguez
Copy link

Thanks for merging this and other PRs @bolandrm, everything working for us when using the current master branch 👍.

@glebm
Copy link
Contributor Author

glebm commented Dec 20, 2018 •
edited
Loading

@bolandrm Can you please release a new version, so that the Rails ecosystem can start moving to libsass?

@bolandrm
Copy link
Member

@glebm 2.1.0 released!

@glebm
Copy link
Contributor Author

glebm commented Dec 20, 2018

@bolandrm Great, thank you!

@gssbzn gssbzn mentioned this pull request Jan 2, 2019
Closed
@ahorek ahorek mentioned this pull request Jan 7, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glebm @deivid-rodriguez @bolandrm