Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Source map 0 7 x #16

Merged
merged 3 commits into from
Apr 16, 2018
Merged

Source map 0 7 x #16

merged 3 commits into from
Apr 16, 2018

Conversation

akkumar
Copy link
Contributor

@akkumar akkumar commented Feb 24, 2018

Upgrade source-map to 0.7.x as needed by downstream projects

Copy link
Member

@xzyfer xzyfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit the package.lock

@akkumar
Copy link
Contributor Author

akkumar commented Feb 24, 2018

@xzyfer - FYI . amended commit here without package-lock.json . Let me know how it looks though.

important: this does break backward compatibility with node.js pre-6 . FYI . Let me know if that would be ok though.

@xzyfer
Copy link
Member

xzyfer commented Feb 24, 2018 via email

@akkumar
Copy link
Contributor Author

akkumar commented Feb 24, 2018

Since source-map 0.6.0+ , the typings are distributed (.d.ts) within source-map package . Previously a separate types/source-map is explicitly necessary that has been deprecated since (after source-map 0.6.0 that is).

FYI more here on - angular/devkit#452 - the bazel build had to be upgraded to depend on source-map 0.7.x .

@akkumar
Copy link
Contributor Author

akkumar commented Feb 24, 2018

If we want to bump to a major version, do we need a separate branch for 0.x to continue with minor versions and releases , while this can go to master for the major version ?

@akkumar
Copy link
Contributor Author

akkumar commented Feb 24, 2018

@xzyfer - major version bumped up given the nature of the changes involving deprecating node<6.

@akkumar
Copy link
Contributor Author

akkumar commented Mar 2, 2018

@xzyfer - what would you suggest to take this one up - a separate branch ?

@xzyfer xzyfer merged commit 026f497 into sasstools:master Apr 16, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants