-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add NORAD as a TLE source. #8
Conversation
This new source allows to use a file with multiple entries as an input to orbit_predictor.
298e95b
to
789bb10
Compare
3 similar comments
789bb10
to
27dd2f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I've been using this with great success in https://github.com/Juanlu001/groundtrack-plotting/ and it's been a while, so @gilgamezh with your permission I'm merging the PR :) |
This MR references satellites by name instead of satellite ID, so it changes the convention that we currently have. Although it is nice to be able to search this way, it creates an inconsistency that we better avoid. Or we keep using ids, or we change everything to names, or we support both transparently here. |
I don't think our convention is clear. The function parameter is called
But even the basic example in the README, that predates this PR, uses a name: https://github.com/satellogic/orbit-predictor/blame/master/README.rst#L38
Perhaps we should clarify this point somewhere, or add new functions that permit retrieving names from IDs. |
This new source allows to use a file with multiple entries as an input
to orbit_predictor.