Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add NORAD as a TLE source. #8

Merged
merged 2 commits into from
Dec 12, 2017

Conversation

inakimalerba
Copy link
Contributor

This new source allows to use a file with multiple entries as an input
to orbit_predictor.

This new source allows to use a file with multiple entries as an input
to orbit_predictor.
@coveralls
Copy link

coveralls commented Nov 28, 2017

Coverage Status

Coverage decreased (-1.8%) to 93.348% when pulling 5d410cc on inakimalerba:norad-source into dd7ff7b on satellogic:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.3%) to 94.789% when pulling 789bb10 on inakimalerba:norad-source into dd7ff7b on satellogic:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.3%) to 94.789% when pulling 789bb10 on inakimalerba:norad-source into dd7ff7b on satellogic:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 94.789% when pulling 789bb10 on inakimalerba:norad-source into dd7ff7b on satellogic:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 94.789% when pulling 789bb10 on inakimalerba:norad-source into dd7ff7b on satellogic:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 94.789% when pulling 789bb10 on inakimalerba:norad-source into dd7ff7b on satellogic:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.1%) to 95.233% when pulling 27dd2f0 on inakimalerba:norad-source into dd7ff7b on satellogic:master.

Copy link
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@astrojuanlu
Copy link
Contributor

I've been using this with great success in https://github.com/Juanlu001/groundtrack-plotting/ and it's been a while, so @gilgamezh with your permission I'm merging the PR :)

@astrojuanlu astrojuanlu merged commit 8d5e80a into satellogic:master Dec 12, 2017
@astrojuanlu astrojuanlu mentioned this pull request Apr 30, 2018
@luciotorre
Copy link
Contributor

This MR references satellites by name instead of satellite ID, so it changes the convention that we currently have. Although it is nice to be able to search this way, it creates an inconsistency that we better avoid. Or we keep using ids, or we change everything to names, or we support both transparently here.

@astrojuanlu
Copy link
Contributor

This MR references satellites by name instead of satellite ID, so it changes the convention that we currently have.

I don't think our convention is clear. The function parameter is called sate_id for all sources, since none of them override TLESource.get_predictor:

def get_tle(self, sate_id, date):

But even the basic example in the README, that predates this PR, uses a name:

https://github.com/satellogic/orbit-predictor/blame/master/README.rst#L38

In [3]: source = EtcTLESource(filename="examples/iss.tle")

In [4]: predictor = source.get_predictor("ISS")

Perhaps we should clarify this point somewhere, or add new functions that permit retrieving names from IDs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants