Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(qq): change internal api error to debug #300

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

idranme
Copy link
Contributor

@idranme idranme commented Jul 19, 2024

Because

await this.internal.deletePrivateMessage(channelId, messageId)

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (e5825f1) to head (4f7f50f).
Report is 100 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   86.88%   86.93%   +0.04%     
==========================================
  Files           1        1              
  Lines         549      551       +2     
  Branches      111      111              
==========================================
+ Hits          477      479       +2     
  Misses         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend changing this behavior. This should be a standard implementation.

If we don't want to have output logs, we should probably change this to debug, and then use the throw-catch approach on the plugin side.

@idranme
Copy link
Contributor Author

idranme commented Jul 20, 2024

Now changed to debug.

@shigma shigma changed the title feat(qq): no warning when a group chat fails to delete a message feat(qq): change internal api error to debug Jul 22, 2024
@shigma shigma merged commit 5b258de into satorijs:master Jul 22, 2024
4 checks passed
@idranme idranme deleted the fix-qq-deleteMessage branch July 22, 2024 16:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants