Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move urllib3 to optional dependency #12

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Move urllib3 to optional dependency #12

merged 1 commit into from
Jul 22, 2022

Conversation

anjakefala
Copy link
Collaborator

No description provided.

@anjakefala anjakefala requested a review from saulpw July 21, 2022 16:46
@anjakefala anjakefala marked this pull request as ready for review July 21, 2022 16:46
@saulpw
Copy link
Owner

saulpw commented Jul 22, 2022

It's not an optional dependency for unzip-http, though we do want it to be for VisiData.

@saulpw saulpw merged commit fced018 into master Jul 22, 2022
@anjakefala
Copy link
Collaborator Author

@saulpw Agreed! This is mostly so that this gets retained the next time we copy over unzip_http.py.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@saulpw saulpw saulpw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anjakefala @saulpw