Merge pull request #2140 from midichef/html_empty_table

[html] prevent error when parsing an empty table
saulpw · Nov 28, 2023 · 35cdf48 · 35cdf48
2 parents a06b3f1 + 7fde6e0
commit 35cdf48
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/tests/golden/pull2140.tsv b/tests/golden/pull2140.tsv
@@ -0,0 +1,3 @@
+name	rows	cols	id	classes
+table_0	0	0		test_empty
+links	0	5		
diff --git a/tests/pull2140.vdj b/tests/pull2140.vdj
@@ -0,0 +1,2 @@
+#!vd -p
+{"sheet": null, "col": null, "row": null, "longname": "open-file", "input": "sample_data/empty-table.html", "keystrokes": "o", "comment": null}
diff --git a/visidata/loaders/html.py b/visidata/loaders/html.py
@@ -154,8 +154,11 @@ def iterload(self):
         if headers:
             it = itertools.zip_longest(*headers, fillvalue='')
         else:
-            it = list(list(x) for x in self.rows.pop(0))
-            it += [''] * (ncols-len(it))
+            if len(self.rows) > 0:
+                it = list(list(x) for x in self.rows.pop(0))
+                it += [''] * (ncols-len(it))
+            else:
+                it = []
 
         for colnum, names in enumerate(it):
             name = '_'.join(str(x) for x in names if x)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		#!vd -p
		{"sheet": null, "col": null, "row": null, "longname": "open-file", "input": "sample_data/empty-table.html", "keystrokes": "o", "comment": null}