Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix parquet reading from zip or s3 #2133

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

takacsd
Copy link
Contributor

@takacsd takacsd commented Nov 22, 2023

This fixes #1916 and provides a nicer fix for #1913.

I'm new here so I'm not entirely sure this doesn't brake something, but I tested loading csv and parquet files from a local folder, from a zip and from s3, and all combinations worked... ;)

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

@saulpw saulpw requested a review from anjakefala November 23, 2023 02:02
Copy link
Owner

@saulpw saulpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @takacsd! This looks reasonable. I'll let @anjakefala look over it and make sure it doesn't break anything else, and if not, we'll definitely take it! It'll be nice to fix #1916.

@anjakefala
Copy link
Collaborator

Everything seems fine!

@anjakefala anjakefala merged commit 3f9b77a into saulpw:develop Nov 23, 2023
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zip] open Parquet files from inside an archive
4 participants