[xml] silence FutureWarning from lxml #2149
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it is. We need that because each colorizer is called for the column headers and column separators, but with row=None or col=None. (The colorizer API has always been a bit frustrating, maybe the |
saulpw
approved these changes
Dec 3, 2023
lxml elements, in a conditional, behave like a list of their children. An element with children evalutes to True, one with no children evaluates to False. Because the behavior is surprising to people, lxml now gives FutureWarnings when the truth value of an Element is checked via "if lxml_elem:". See https://lxml.de/tutorial.html#elements-are-lists
midichef
force-pushed
the
xml_futurewarning
branch
from
5d7834f to
66f5298
Compare
|
I just changed the commit message to say |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewing an xml file gives this error:
The warning relates to the surprising behavior of the truth value of lxml Element, which is the same as the truth value of a list of its children. That may not be what people expect when they do
if lxml_element:. So lxml gives aFutureWarningin conditionals like that.To silence the warning, I modified the colorizer function to test for
r is not Noneinstead of justr.Is this the right way to test for a row? I'm not sure if there is another type of row where
if rmeans more thanif r is not None?