[tests-] add more deps to test extras #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! =) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some libraries to the list of minimal packages needed to get the tests to pass.
Right now, two of them are not strictly required to get the tests to pass:
dnslibanddpkt, but they are probably meant to be. They are used bytests/messenger-nosave.vd. If they're not installed, the tests will have output fromvd.fail():External package "dpkt" not installed; run: pip install dpkt. But since this test is -nosave.vd and doesn't save any data to compare to golden withgit diff, the exit code ofdev/tests.shis still 0 on my setup.