Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[disp] Rename disp_pixel_random to disp_graph_pixel_random #2664

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jan 4, 2025

Fixes #2661

Do I need to add anything to make the old name still work?

@cool-RR cool-RR changed the title [disp] Rename disp_pixel_random to disp_graph_pixel_random #2661 [disp] Rename disp_pixel_random to disp_graph_pixel_random Jan 4, 2025
@cool-RR cool-RR marked this pull request as ready for review January 4, 2025 21:54
@cool-RR
Copy link
Contributor Author

cool-RR commented Jan 10, 2025

Bump.

@saulpw
Copy link
Owner

saulpw commented Jan 12, 2025

Thanks for pulling this together, @cool-RR. We do need to add a line to the end of deprecated.py:

vd.optalias('disp_pixel_random', 'disp_graph_pixel_random')  #2661

But if that's the only disp_pixel_random remaining in the codebase after this PR, then we're good.

@cool-RR
Copy link
Contributor Author

cool-RR commented Jan 12, 2025

Done.

Copy link
Owner

@saulpw saulpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing an inconsistency, @cool-RR !

@anjakefala anjakefala merged commit e56bbaf into saulpw:develop Jan 13, 2025
14 checks passed
@cool-RR
Copy link
Contributor Author

cool-RR commented Jan 20, 2025

How do I do

options.disp_pixel_random = True

In my .visidatarc such that it works both before the change and after it, without showing any warning that the option doesn't exist?

@cool-RR
Copy link
Contributor Author

cool-RR commented Jan 22, 2025

@saulpw Any idea about the question above?

@saulpw
Copy link
Owner

saulpw commented Jan 22, 2025

I have some thoughts but nothing immediate, and my dayjob means that I don't really have time to respond during the week. Please be patient.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename options.disp_pixel_random to include graph
3 participants