Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add execution of diktat with glob paths in build_and_test.yml #1397

Closed
3 tasks done
petertrr opened this issue Jun 23, 2022 · 0 comments · Fixed by #1544
Closed
3 tasks done

Add execution of diktat with glob paths in build_and_test.yml #1397

petertrr opened this issue Jun 23, 2022 · 0 comments · Fixed by #1544
Assignees
@0x6675636b796f75676974687562
Labels
bug Something isn't working tests Improve testing
Milestone
1.2.4

Comments

@petertrr
Copy link
Member

petertrr commented Jun 23, 2022 •
edited by 0x6675636b796f75676974687562
Loading

Now we test both relative and absolute path, but with specific files. Need to add paths with globs (**, *) since it seems that absolute paths with ** do not work on Windows with ktlint 0.45.x

Depends on:
@petertrr petertrr added bug Something isn't working tests Improve testing labels Jun 23, 2022
@petertrr petertrr mentioned this issue Jun 23, 2022
Open
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 changed the title Add execution of diktat with glob paths in build_and_test.yml Add execution of diktat with glob paths in build_and_test.yml Aug 15, 2022
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added this to the 1.2.4 milestone Oct 25, 2022
0x6675636b796f75676974687562 added a commit that referenced this issue Oct 31, 2022
@0x6675636b796f75676974687562
Run Diktat from CLI using glob (**/*) paths
48a4684 
### What's done:

This change is intended to test that ktlint (0.47+) is indeed capable of parsing
Ant wildcard patterns (`**/*.kt` etc.).

Fixes #1397.
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Oct 31, 2022
@0x6675636b796f75676974687562
Run Diktat from CLI using glob (**/*) paths (#1544)
3759312 
### What's done:

This change is intended to test that ktlint (0.47+) is indeed capable of parsing
Ant wildcard patterns (`**/*.kt` etc.).

Fixes #1397.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@0x6675636b796f75676974687562 0x6675636b796f75676974687562

Labels
bug Something isn't working tests Improve testing
Projects
None yet
Milestone
1.2.4
Development

Successfully merging a pull request may close this issue.

Run Diktat from CLI using glob (**/*) paths saveourtool/diktat
2 participants
@petertrr @0x6675636b796f75676974687562