Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add various missing items from Celery (and related from billiard) #161

Merged
merged 5 commits into from
May 11, 2024

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented May 11, 2024

Fixes #158, #159 and #160

This all started from stubgen stubs and then has been assortedly either tidyed up or just removing all the extra defintions that would require extra exploration work. It definitely adds a bunch of extra features and is an improvement over the existing bits, but will need reworking to add the extra bits at some point.

@sbdchd
Copy link
Owner

sbdchd commented May 11, 2024

Looks good! CI has one minor thing:

+ ./.venv/bin/mypy tests
typings/celery/app/base.pyi:148:5: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [misc]
Found 1 error in 1 file (checked 1 source file)

@sbdchd sbdchd added the automerge auto merge PRs using kodiak label May 11, 2024
@sbdchd
Copy link
Owner

sbdchd commented May 11, 2024

Thank you!!

@kodiakhq kodiakhq bot merged commit 1179751 into sbdchd:main May 11, 2024
2 checks passed
@palfrey palfrey deleted the various-missing branch May 11, 2024 22:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
automerge auto merge PRs using kodiak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing components properties from Worker
2 participants