-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Publish wheel for macos-arm64, manylinux-x86_64 and manylinux-arm64 #138
Conversation
Thanks a lot for doing this. I'll look into it as soon as I have a bit of free time as I know little about wheels so I want to properly understand what this does. |
I also had a look at `cibuildwheel` that is specialized in making wheel for the different platforms, but I thought it was overkill to use it. But maybe it simplifies the scripts.
…On 23 July 2024 19:17:01 GMT+01:00, Louis Sautier ***@***.***> wrote:
Thanks a lot for doing this. I'll look into it as soon as I have a bit of free time as I know little about wheels so I want to properly understand what this does.
--
Reply to this email directly or view it on GitHub:
#138 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Hello, did you have time to test this PR? Thanks! |
Hi @getzze I'm sorry I haven't taken time to review this. I will try to do it soon. |
Hi, and once again sorry for the really long delay in my review. I've started reviewing the PR and I think I understand most of it. I left a few comments on the code.
I know sooner or later I'll have to fix the build so maybe now is the right time? |
After reading the warnings, I stumbled on https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary. It looks like installing the |
I think it makes sense to switch to I can open another PR with the change to hatch 🙂. But it's better to keep it separate from this PR, right? |
Or we can just drop this PR entirely, whatever is easiest for you. If it's too much work, we can merge this first, I'd just like to understand what the try/except block does. |
Ah I had forgotten about the modifications in |
use pdm as build backend https://github.com/TensoRaws/pymediainfo-tensoraws |
Closing in favour of #140. |
fixes #127, #128
Taking inspiration from:
https://github.com/shakfu/cyfaust/blob/main/docs/devnotes/universal2.md
https://stackoverflow.com/questions/76450587/python-wheel-that-includes-shared-library-is-built-as-pure-python-platform-indep
I checked
manylinux-x86_64
was correct with auditwheel, maybe checking withauditwheel
could be added to thetox
config or to theappveyor
config.