Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Error if --solcoverjs passed but file is nonexistent #889

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

area
Copy link
Contributor

@area area commented Jul 3, 2024

It's been a while 😅 - hope things are good on your side.

While reworking my test suite, I lost a lot of time to this peculiarity and a hard-to-spot typo on my side, so thought I'd see if there was an appetite to saving other people the bother down the line. I realise this is a breaking change though; would be happy to turn it in to a warning rather than an outright failure, if that's a concern.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (04d178e) to head (b9e4677).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #889   +/-   ##
=======================================
  Coverage   96.62%   96.63%           
=======================================
  Files          19       19           
  Lines        1066     1069    +3     
=======================================
+ Hits         1030     1033    +3     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgewecke cgewecke self-requested a review July 4, 2024 05:24
Copy link
Member

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! 👋

Thanks for this, definitely how it should be :)

@cgewecke cgewecke merged commit adaeb54 into master Jul 4, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants