queueing: Fix cluster duplicate handler dying #162
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With python3 the cluster duplicate handler would die from RuntimeErrors due to the items() accessor of the duplicate backlog dict being a view/iterator that doesn't respond well to the dict changing while being iterated. Prevent the RuntimeError by iterating over the items of a copy of the dict while changing the original, similar to what we're doing in the cuckoo job tracke for alomst the same reason already. Fixes scVENUS#160.
|
This is an exact duplicate of #161 |
|
Yeah, this is against the 2.0 branch as backport for a potential v2.0.1 bugfix release. :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be backported to 2.0 as well since it's a serious defect in a major functionality of the release.
With python3 the cluster duplicate handler would die from RuntimeErrors
due to the items() accessor of the duplicate backlog dict being a
view/iterator that doesn't respond well to the dict changing while being
iterated. Prevent the RuntimeError by iterating over the items of a copy
of the dict while changing the original, similar to what we're doing in
the cuckoo job tracke for alomst the same reason already.
Fixes #160.