Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala-js-dom currently supports onmousewheel but as written on MDN:
As mentioned above it is not supported on Firefox. This PR adds onwheel.
You can test with the following code:
WheelEvent
for the deprecatedonmousewheel
. I didn't want to change the Scala-js-dom code as it would break the compatibility for the current users. Note: on my computer, Chrome returns aWheelEvent
for both events. Here is a screenshot showing the output of the above snippet:Also I didn't add documentation. Feel free to ask me to do it if required