Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #445 return type for Header#get #473

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Fix #445 return type for Header#get #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcfd017
Fix #445 return type for Header#get
armanbilge Aug 11, 2021
f6a8e6a
prePR
armanbilge Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ experimental/Fullscreen.FullscreenDocument[JT] var onfullscreenerror: js.Functio
experimental/Fullscreen.FullscreenElement[JT] def requestFullscreen(): js.UndefOr[js.Promise[Unit]]
experimental/Headers[JC] def append(name: ByteString, value: ByteString): Unit
experimental/Headers[JC] def delete(name: ByteString): Unit
experimental/Headers[JC] def get(name: ByteString): js.UndefOr[ByteString]
experimental/Headers[JC] def get(name: ByteString): ByteString
experimental/Headers[JC] def getAll(name: ByteString): Sequence[ByteString]
experimental/Headers[JC] def has(name: ByteString): Boolean
experimental/Headers[JC] @JSName(js.Symbol.iterator) def jsIterator(): js.Iterator[js.Array[ByteString]]
Expand Down
2 changes: 1 addition & 1 deletion api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ experimental/Fullscreen.FullscreenDocument[JT] var onfullscreenerror: js.Functio
experimental/Fullscreen.FullscreenElement[JT] def requestFullscreen(): js.UndefOr[js.Promise[Unit]]
experimental/Headers[JC] def append(name: ByteString, value: ByteString): Unit
experimental/Headers[JC] def delete(name: ByteString): Unit
experimental/Headers[JC] def get(name: ByteString): js.UndefOr[ByteString]
experimental/Headers[JC] def get(name: ByteString): ByteString
experimental/Headers[JC] def getAll(name: ByteString): Sequence[ByteString]
experimental/Headers[JC] def has(name: ByteString): Boolean
experimental/Headers[JC] @JSName(js.Symbol.iterator) def jsIterator(): js.Iterator[js.Array[ByteString]]
Expand Down
2 changes: 1 addition & 1 deletion src/main/scala/org/scalajs/dom/experimental/Fetch.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ class Headers(map: HeadersInit = js.Array[js.Array[String]]())
*
* @param name a ByteString, ie. only ASCII chars
*/
def get(name: ByteString): js.UndefOr[ByteString] = js.native
def get(name: ByteString): ByteString = js.native

/**
* The getAll() method of the Headers interface returns an array of all the
Expand Down