Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Set version scheme for publishing #480

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Set version scheme for publishing #480

merged 3 commits into from
Aug 20, 2021

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Aug 13, 2021 •
edited
Loading

I'm not sure what was used in the 0.x stage of this project, so I'm specifying semver-spec and not early-semver to be cautious, doubt it'll matter to anyone.

@armanbilge armanbilge requested a review from japgolly August 13, 2021 00:19
@japgolly
Copy link
Contributor

WDYT @sjrd ? How strict were you with the 0.x releases?

@armanbilge
Copy link
Member Author

If I had to guess (and knowing @sjrd!) almost definitely early-semver, that's what Scala.js itself uses.

@japgolly japgolly added this to the v1.2.0 milestone Aug 13, 2021
@sjrd
Copy link
Member

sjrd commented Aug 13, 2021

It's been early-semver, yes, indeed.

@japgolly japgolly merged commit 0a35f9c into series/1.x Aug 20, 2021
@japgolly japgolly deleted the topic/version-scheme branch August 20, 2021 01:58
@japgolly
Copy link
Contributor

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@japgolly japgolly Awaiting requested review from japgolly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@armanbilge @japgolly @sjrd