Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The great migration to dom #588

Merged
merged 22 commits into from
Oct 17, 2021
Merged

The great migration to dom #588

merged 22 commits into from
Oct 17, 2021

Conversation

armanbilge
Copy link
Member

Trying to wrap up #545.

@armanbilge
Copy link
Member Author

Phew 😅 that's the whole lot. I'd be shocked if this is 100% perfect, but if any issues do come up we should be able to fix them binary-compatibly.

@armanbilge armanbilge marked this pull request as ready for review September 28, 2021 02:46
@armanbilge armanbilge requested a review from japgolly September 28, 2021 02:46
@armanbilge armanbilge marked this pull request as draft September 28, 2021 09:02
@armanbilge armanbilge marked this pull request as ready for review September 28, 2021 23:13
@armanbilge armanbilge mentioned this pull request Oct 10, 2021
Merged
@armanbilge armanbilge linked an issue Oct 10, 2021 that may be closed by this pull request
Move more packages into dom #545
Closed
14 tasks
japgolly
japgolly requested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@japgolly japgolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments but fantastic work getting this done @armanbilge ! It would've involved quite a bit of tedium.

armanbilge and others added 2 commits October 11, 2021 19:55
@armanbilge armanbilge requested a review from japgolly October 13, 2021 18:34
@armanbilge armanbilge mentioned this pull request Oct 13, 2021
Closed
@armanbilge armanbilge added this to the v2.0.0 milestone Oct 16, 2021
japgolly
japgolly requested changes Oct 17, 2021
View reviewed changes
Copy link
Contributor

@japgolly japgolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two minor changes, and the crypto problem. Maybe we could merge with crypto as is and then I take a shot at it in a follow up PR?

@japgolly japgolly mentioned this pull request Oct 17, 2021
Closed
@armanbilge
Copy link
Member Author

Thanks again for your careful eye! Fixed those TrackEvents that slipped through and should be good to go when green.

@armanbilge armanbilge requested a review from japgolly October 17, 2021 07:47
@japgolly japgolly merged commit af021a7 into master Oct 17, 2021
@japgolly japgolly deleted the topic/great-migration branch October 17, 2021 08:23
@japgolly
Copy link
Contributor

LGTM, you legend. Thanks for your work on this mammoth migration!!

@armanbilge
Copy link
Member Author

Actually this was made SO much easier after you split all the files! So much credit to you as well that was a life saver!!

@armanbilge armanbilge mentioned this pull request Oct 21, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sjrd sjrd sjrd left review comments

@japgolly japgolly japgolly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Move more packages into dom
3 participants
@armanbilge @japgolly @sjrd