Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change Storage#length to a def instead of var #737

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Change Storage#length to a def instead of var #737

merged 1 commit into from
Nov 2, 2022

Conversation

zetashift
Copy link
Contributor

My feelings about this PR
image

armanbilge
armanbilge approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, this is a big help 😃

@armanbilge armanbilge linked an issue Nov 2, 2022 that may be closed by this pull request
Storage#length should be a def #729
Closed
@armanbilge armanbilge changed the title Change Storage#length to a def instead of var #729 Change Storage#length to a def instead of var Nov 2, 2022
@armanbilge armanbilge merged commit 714813e into scala-js:main Nov 2, 2022
@zetashift zetashift deleted the fix/#729 branch February 20, 2023 01:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage#length should be a def
2 participants
@zetashift @armanbilge