Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add alias to HTMLDialogElement in html object. #753

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Add alias to HTMLDialogElement in html object. #753

merged 2 commits into from
Dec 19, 2022

Conversation

Lasering
Copy link
Contributor

Add alias to HTMLDialogElement.

@Lasering
Update html.scala
153a6a1 
Add alias to HTMLDialogElement
@Lasering Lasering changed the title Update html.scala Add alias to HTMLDialogElement in html object. Dec 16, 2022
@zetashift
Copy link
Contributor

The CI seems to fail because, sbt prePR command wasn't run, and no new api-reports.txt were commited.
Can you try running that command? More information here: https://github.com/scala-js/scala-js-dom/blob/main/CONTRIBUTING.md#submitting-a-pr

armanbilge
armanbilge approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@armanbilge armanbilge merged commit 635de87 into scala-js:main Dec 19, 2022
@Lasering Lasering mentioned this pull request Dec 19, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lasering @zetashift @armanbilge