Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add options parameter to Document#createElement #788

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Add options parameter to Document#createElement #788

merged 4 commits into from
Jul 20, 2023

Conversation

alfonso-landin
Copy link
Contributor

@alfonso-landin
Add options parameter to Document#createElement
9c623c6 
Also to Document#createElementNS
zetashift
zetashift approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@zetashift zetashift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, this looks good, thank you :D!

armanbilge
armanbilge approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@armanbilge armanbilge merged commit d157768 into scala-js:main Jul 20, 2023
@zetashift zetashift mentioned this pull request Jul 26, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zetashift zetashift zetashift approved these changes

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfonso-landin @zetashift @armanbilge