Filter functions and typedefs by prefix #25
Conversation
| llvm::cl::opt<std::string> LibName("name", llvm::cl::cat(Category)); | ||
| llvm::cl::opt<std::string> StdHeaders("std-headers", llvm::cl::cat(Category)); | ||
| llvm::cl::opt<bool> PrintHeadersLocation("location", llvm::cl::cat(Category)); | ||
| llvm::cl::opt<std::string> ExcludePrefix("exclude-prefix", llvm::cl::cat(Category)); |
There was a problem hiding this comment.
Eventually it would be nice to support multiple values.
Main.cpp
Outdated
| int main(int argc, char *argv[]) { | ||
| llvm::cl::OptionCategory Category("Binding Generator"); | ||
| llvm::cl::extrahelp CommonHelp(clang::tooling::CommonOptionsParser::HelpMessage); | ||
| llvm::cl::extrahelp MoreHelp("\nProduce Bindings for scala native. Please specify lib name wit parameter name\n"); |
There was a problem hiding this comment.
Would be nice to also fix the typo: wit -> with
| int main(int argc, char *argv[]) { | ||
| llvm::cl::OptionCategory Category("Binding Generator"); |
Utils.h
Outdated
| static bool typeUsesOtherType(const std::string &checkedType, const std::string &type) { | ||
| // TODO: find better way to check it | ||
| return checkedType == type || | ||
| checkedType == "native.Ptr[" + type + "]"; |
There was a problem hiding this comment.
Should this also check for use with native.CArray?
There was a problem hiding this comment.
@jonas, yes, but there are also function pointers :( in that case it is possible to search for a substring ", type " it doesn't seems right.
Will it make sense to add Type class to IR? There will be 4 subclasses of this class:
PointerTypeArrayTypeFunctionPointerTypeStruct/Union type(maybe it can be justType)
Types may contain other types.
There will be right way to check if a type uses another type.
Also Type will handle reserved words, so this part of type translation will be more clear.
There was a problem hiding this comment.
If we decide to do it then it should be separate PR. Now I will continue with this version.
There was a problem hiding this comment.
It would be nice to have a proper way to represent types. Eventually we can look into having Type reference the current Struct/Union/TypeDef classes.
tests/samples/PrivateMembers.h
Outdated
| struct structWithPrivateType { | ||
| int field1; | ||
| __int32_t field2; | ||
| }; // should be removed |
There was a problem hiding this comment.
Removing the whole struct seems wrong. The same for the enum. Do we have any good examples of this in the wild. The C socket structs have some platform specific members I think.
kornilova203
force-pushed
the
filter-private-declarations
branch
from
d95b35b to
e93d429
Compare
kornilova203
changed the title
kornilova203
force-pushed
the
filter-private-declarations
branch
from
e93d429 to
3adbac8
Compare
|
So now it removes:
|
Add option
--exclude-prefixthat allows to specify prefix of declarations that should be excluded.If chain of typedefs has aliases that should be excluded then this aliases are replaced by actual types:
=>
Also functions, structs, enums, union and typdefs are excluded if they use excluded types.
Issue #3