add option to add files in container

[mberndt123]

Hi,

I've added the possibility to add files that will be mounted into the scala-steward container. I needed this for two things:

• for use with the --repo-config option which requires a file. I could of course put this into each individual repo, but I want to be able to configure it the same way across repos
• for the /root/.sbt/1.0/credentials.sbt file where I read the Nexus credentials from the env variables. again, I don't want to modify lots of different repos to do this.

Let me know what you think.

[jsoref]

This looks interesting. As it happens, we planned to look into upgrading scala steward this month...

[mberndt123]

Thanks for the review, I've rebased the changes and also adjusted the version from latest-release to 0.30.2.

[mberndt123]

I've also adjusted version and appVersion in Chart.yaml

[mberndt123]

@jsoref can you take another look?

[jsoref]

Thanks! The changes look right. I want to test this a bit before I merge. I'm busy today and am hoping to get a coworker to look soon (maybe tomorrow if I'm lucky). If I don't respond by Monday, please tag me on Tuesday.

[mberndt123]

OK cool

[mberndt123]

Ping @jsoref!

I've pushed another change to correctly handle the case where additionalFiles is empty.

[jsoref]

Fwiw, I've asked someone to run a test of this, so hopefully they'll check tomorrow and have feedback for me by Monday.

[mberndt123]

I'm running this right now and it's working fine for me (I've added a credentials configuration for sbt and a repo configuration for scala-steward), so I'm not sure what more testing it is you need to do. But go ahead, do your thing.

[jsoref]

Sorry... sometimes I'm overly cautious. I'm used to things going wrong. Many things I've tried this week have gone wrong.

What I can say is that we tested the basic chart from this PR and it worked. We haven't had time to test the volume mounts although I absolutely expect them to work.

I'm going to check with a coworker and I think I'll merge by Monday.

[mberndt123]

Thanks for merging @jsoref !

[jsoref]

Thanks for contributing and sorry about the long time to merge.