Fix bug in handling repos-file
input
#25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 The bug
Inputs read by
core.getInput
are initialized as''
if they aren't present. However we are handling them asundefined
:✔️ The solution
First of all
action.yml
shouldn't contain anydefault: ''
for non-required inputs, since that is already the initial value.Second of all inputs should be read as
string
and checked using:What other changes are included in this PR?
A whole suite of tests for the
check.repoFiles()
method has been included so we ensure this error won't happen again in the future.References
This fixes #21