Skip to content

Let Scala Steward send upgrades to Scala.js 1.8.0. #2402

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

sjrd
Copy link
Contributor

@sjrd sjrd commented Dec 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #2402 (f4600f8) into master (c53805c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2402   +/-   ##
=======================================
  Coverage   80.41%   80.41%           
=======================================
  Files         140      140           
  Lines        2384     2384           
  Branches       37       37           
=======================================
  Hits         1917     1917           
  Misses        467      467           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53805c...f4600f8. Read the comment docs.

@fthomas fthomas merged commit 0520fd2 into scala-steward-org:master Dec 10, 2021
@sjrd
Copy link
Contributor Author

sjrd commented Dec 10, 2021

Thanks @fthomas :) I like this new process. I hope it's not a burden for you!

@sjrd sjrd deleted the go-scalajs-1.8.0 branch December 10, 2021 16:19
@fthomas
Copy link
Member

fthomas commented Dec 12, 2021

You're welcome! And no, it is not a burden for me.

Btw, it took a little while for Scala Steward to create PRs for Scala.js 1.8.0 this time since it was busy with the sbt 1.5.6 update and it is currently slowed down by GitHub's secondary rate limiting (#2355) which we are not yet mitigating.

@fthomas
Copy link
Member

fthomas commented Dec 12, 2021

Another thing I noticed is this PR com-lihaoyi/mill#1608 which suggests to me that scalajs-sbt-test-adapter is missing in the above list of ignored artifacts.

@sjrd
Copy link
Contributor Author

sjrd commented Dec 13, 2021

Oh, well spotted! It was already there, but I had the wrong artifact name. Here is a PR to fix it: #2405.

@fthomas fthomas added this to the 0.14.0 milestone Dec 13, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants