Skip to content

Add simple instance-wide PR throttle #2970

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add simple instance-wide PR throttle #2970

wants to merge 2 commits into from

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Feb 11, 2023

This adds a simple instance-wide PR throttle. It can be activated by adding the --pr-throttle-skip=$duration or --pr-throttle-wait=$duration command-line options. With --pr-throttle-skip=$duration Scala Steward will skip creating PRs for $duration after the last PR. With --pr-throttle-wait=$duration it actively waits until $duration is elapsed before creating the next PR.

Closes #2934, closes #2355

@armanbilge
Copy link
Contributor

Thank you so much! This strategy is easy to understand and will work well for us 👍

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 90.96% // Head: 90.68% // Decreases project coverage by -0.28% ⚠️

Coverage data is based on head (1783dd9) compared to base (ef3cd47).
Patch coverage: 69.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2970      +/-   ##
==========================================
- Coverage   90.96%   90.68%   -0.28%     
==========================================
  Files         157      159       +2     
  Lines        3209     3253      +44     
  Branches      242      224      -18     
==========================================
+ Hits         2919     2950      +31     
- Misses        290      303      +13     
Impacted Files Coverage Δ
...ala/org/scalasteward/core/application/Config.scala 50.00% <ø> (ø)
...org/scalasteward/core/application/StewardAlg.scala 42.85% <0.00%> (+0.43%) ⬆️
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 19.07% <0.00%> (-0.13%) ⬇️
...calasteward/core/nurture/PullRequestThrottle.scala 11.11% <11.11%> (ø)
.../scala/org/scalasteward/core/application/Cli.scala 100.00% <100.00%> (ø)
...la/org/scalasteward/core/application/Context.scala 75.94% <100.00%> (+0.62%) ⬆️
...scala/org/scalasteward/core/util/SimpleTimer.scala 100.00% <100.00%> (ø)
...teward/core/repoconfig/ValidateRepoConfigAlg.scala 85.71% <0.00%> (-14.29%) ⬇️
...org/scalasteward/core/coursier/VersionsCache.scala 85.71% <0.00%> (-4.29%) ⬇️
...ain/scala/org/scalasteward/core/data/Version.scala 100.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@barryoneill
Copy link
Contributor

Hi @fthomas - is there any plan to bring this in?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More strategies for (org-level) throttling of PRs Deal with GitHub's secondary rate limit
3 participants