-
Notifications
You must be signed in to change notification settings - Fork 1k
Why scala 3 tabs code #2510
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Why scala 3 tabs code #2510
Conversation
Im not so sure about adding translations until the book is stable, which could be another few months from now. i.e. the content might change a lot in the English version. What do you think? |
@jxnu-liguobin there are many files changed in this PR that don't match just the "why scala 3" page, is that intentional? |
In fact, I don't know why this PR is exists. The new commits seem for other issues. Because this PR is based on a PR that has not yet been merged. |
needs rebase now that #2394 is merged |
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
b9a643e
to
1360cae
Compare
I just did the rebase - I see now it really is just adding code tabs, so ill review |
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
add tabs for code