Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove use of deprecated Future.onSuccess #72

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Remove use of deprecated Future.onSuccess #72

merged 1 commit into from
Mar 2, 2018

Conversation

NthPortal
Copy link
Contributor

@NthPortal NthPortal mentioned this pull request Feb 22, 2018
Merged
@SethTisue
Copy link
Member

couldn't we use .foreach here instead of .onComplete?

@NthPortal
Copy link
Contributor Author

Probably, yeah. I'll add a switch to that as a second commit, and then squash if it builds

@SethTisue SethTisue requested a review from benhutchison March 2, 2018 01:17
@benhutchison benhutchison merged commit 7a0176f into scala:2.0.x Mar 2, 2018
@SethTisue
Copy link
Member

thanks, Nth!

@NthPortal
Copy link
Contributor Author

No problem!

@NthPortal NthPortal deleted the future-onsuccess branch March 3, 2018 04:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benhutchison benhutchison benhutchison approved these changes

@SethTisue SethTisue SethTisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NthPortal @SethTisue @benhutchison