Assume some capture sets in user-defined types #12892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same direction when re-typing during refinement
We are throwing away the refined trees, so we should keep the old type variables unchanged.
Outer references cannot be re-typed with the usual typedSelect algorithm. Their types have to be preserved. Test case is pos/i8892.scala.
Prefer old instance over extremal bound Nothing or Any when refining
- that way we avoid an overly long valOrDefDefSig - the method can be reused in RefineTypes
Add refiner tests that exercise the setting
and drop unused hook method
This reverts commit e96f653. Since we are now our own branch on origin, there's no need to deviate in targeting a minor version. We are targeting no specific version at the present time, so there's no need to deviate from the standard build
Drop the restriction that the type parameters must be following at least one value parameter clause.
Drop implementation restriction for polymorphic functions
The previous condition did not work for qualifiers with the
```
PolyFunction { ... } retains ...
```
A substitution was missing for type parameters that appear in the capture set of the constructor.
Strip off capturing types before decomposing a function prototype
odersky
added
the
cc-experiment
Shallow capture sets
If a variable in a capture set gets instantiated, the capture set has to update itself as well.
odersky
force-pushed
the
simplify-retains
branch
from
4a8ad7d to
4e0d18d
Compare
|
Based on old ReTyper. All interesting commits are in branch cc-experiment-retyper |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12871 for background
Based on #12875