Improve error message for inaccessible types #18406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicolasstucki
commented
Aug 16, 2023
•
nicolasstucki
commented
- If accessed from an object:
- If accessed from a package:
nicolasstucki
force-pushed
the
improve-error-message-for-inaccessible-types
branch
6 times, most recently
from
1c0165d
to
ee9ab21
Compare
smarter
requested changes
Aug 17, 2023
tests/neg/not-accessible.check
Outdated
| @@ -9,12 +9,12 @@ | |||
| -- [E173] Reference Error: tests/neg/not-accessible.scala:13:23 -------------------------------------------------------- | |||
| 13 | def test(a: A) = a.x // error | |||
| | ^^^ | |||
| | value x cannot be accessed as a member of (a : foo.A) from package object not-accessible$package. | |||
| | value x cannot be accessed as a member of (a : foo.A) from package object bar. | |||
There was a problem hiding this comment.
That's wrong, the package object bar is always an object named package in the package bar, I think this should say "from a top-level definition in package bar"
nicolasstucki
force-pushed
the
improve-error-message-for-inaccessible-types
branch
from
ee9ab21
to
9fcb939
Compare
nicolasstucki
force-pushed
the
improve-error-message-for-inaccessible-types
branch
from
9fcb939
to
1920336
Compare
smarter
reviewed
Oct 6, 2023
tests/neg/i12573.check
Outdated
Comment on lines
7
to
9
| | method getDFType cannot be accessed as a member of DFType.type from top-level definition in package <empty>. | ||
| | Access to protected method getDFType not permitted because enclosing top-level definition in package <empty> | ||
| | is not a subclass of object DFType where target is defined |
There was a problem hiding this comment.
It should be "from the top-level definitions" since we're talking about the object here, but also "top-level definitions is not a subclass of ..." isn't really meaningful, the explanation could be simplified to just say "Protected method getDFType can only be accessed from object DFType or one of its subclasses" (and the "or one of its subclasses" part could be dropped for objects too)
nicolasstucki
force-pushed
the
improve-error-message-for-inaccessible-types
branch
from
5003e87
to
1472b7a
Compare
WojciechMazur
added a commit
that referenced
this pull request
Jun 22, 2024
Backports #18406 to the LTS branch. PR submitted by the release tooling. [skip ci]
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.