Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Only lift inner expressions when lifting repeated Typed arguments #18424

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Only lift inner expressions when lifting repeated Typed arguments #18424

merged 1 commit into from
Aug 28, 2023

Conversation

KacperFKorban
Copy link
Member

closes lampepfl#18233

@KacperFKorban KacperFKorban marked this pull request as ready for review August 21, 2023 09:15
@KacperFKorban KacperFKorban removed the request for review from TheElectronWill August 22, 2023 20:30
sjrd
sjrd approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that looks so much better. :)

@KacperFKorban KacperFKorban changed the title Convert lifted non-SeqLiteral vararg splices into Seqs Only lift inner expressions when lifting repeated Typed arguments Aug 28, 2023
@KacperFKorban
Copy link
Member Author

Looks like a rebase was needed.

@sjrd sjrd merged commit 5318d68 into scala:main Aug 28, 2023
@sjrd sjrd deleted the fix-i18233 branch August 28, 2023 22:37
@Kordyjan Kordyjan mentioned this pull request Dec 11, 2023
Merged
Kordyjan added a commit that referenced this pull request Dec 13, 2023
@Kordyjan
Backport "Only lift inner expressions when lifting repeated Typed a…
067ec76 
…rguments" to LTS (#19234)

Backports #18424 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.

coverage + vararg splicing causes ClassCastException
3 participants
@KacperFKorban @sjrd @Kordyjan