Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bugfix: No signature help for local methods #18594

Merged
merged 1 commit into from
Sep 26, 2023
Merged

bugfix: No signature help for local methods #18594

merged 1 commit into from
Sep 26, 2023

Conversation

jkciesluk
Copy link
Contributor

No description provided.

@jkciesluk jkciesluk mentioned this pull request Sep 26, 2023
Merged
tgodzik
tgodzik approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Sep 26, 2023
@tgodzik tgodzik merged commit 6c05c36 into scala:main Sep 26, 2023
18 checks passed
@jkciesluk jkciesluk deleted the sig-help-local branch September 29, 2023 10:43
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 19, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "bugfix: No signature help for local methods" to LTS (#20623)
d74d462 
Backports #18594 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur mentioned this pull request Jun 20, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "bugfix: No signature help for local methods" to LTS (#20680)
d4dc765 
Backports #18594 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkciesluk @tgodzik @Kordyjan