Skip to content

Fix #18816: Transfer the span of rewired This nodes in fullyParameterizedDef. #18840

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix #18816: Transfer the span of rewired This nodes in fullyParameterizedDef. #18840

merged 1 commit into from
Nov 6, 2023

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Nov 3, 2023

No description provided.

@sjrd
Copy link
Member Author

sjrd commented Nov 3, 2023

@nicolasstucki Where can we test generated positions? I guess you had to do some of that for inline's and macros?

@nicolasstucki nicolasstucki linked an issue Nov 6, 2023 that may be closed by this pull request
Wrong debug line in a local method of a value class that captures a using instance #18816
Closed
@nicolasstucki
Copy link
Contributor

You can add a test in DottyBytecodeTests.scala. This test might be a good template for your use case https://github.com/lampepfl/dotty/blob/main/compiler/test/dotty/tools/backend/jvm/DottyBytecodeTests.scala#L1604-L1633. Otherwise you can have a look at some of the tests in InlineBytecodeTests.scala that involve LineNumber.

@sjrd sjrd marked this pull request as ready for review November 6, 2023 09:19
@sjrd
Copy link
Member Author

sjrd commented Nov 6, 2023

Great, thanks! I added a test there. Can I ask you to review this one? (the fix itself is trivial)

@sjrd sjrd requested a review from nicolasstucki November 6, 2023 09:20
@sjrd sjrd assigned nicolasstucki and unassigned sjrd Nov 6, 2023
@sjrd sjrd enabled auto-merge November 6, 2023 09:50
@sjrd sjrd merged commit eb7fbff into scala:main Nov 6, 2023
@sjrd sjrd deleted the fix-i18816 branch November 6, 2023 10:51
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jul 2, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 3, 2024
@WojciechMazur
Backport "Fix #18816: Transfer the span of rewired This nodes in `f…
528f3b7 
…ullyParameterizedDef`." to LTS (#20966)

Backports #18840 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Wrong debug line in a local method of a value class that captures a using instance
3 participants
@sjrd @nicolasstucki @Kordyjan