Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix #19019: Always type self ValDefs in their outer context. #19030

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix #19019: Always type self ValDefs in their outer context. #19030

merged 1 commit into from
Nov 23, 2023

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Nov 23, 2023

No description provided.

@sjrd sjrd requested a review from odersky November 23, 2023 10:25
sjrd
sjrd commented Nov 23, 2023
View reviewed changes
tests/printing/i19019.check
Container.this.NonStaticObjectWithSelf =
new Container.this.NonStaticObjectWithSelf()
final module class NonStaticObjectWithSelf() extends Object() {
self: Container.this.NonStaticObjectWithSelf.type =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line used to read

self: this.type =>

before the fix.

odersky
odersky approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@odersky odersky merged commit bd5a2ae into scala:main Nov 23, 2023
19 checks passed
@odersky odersky deleted the fix-inner-object-self-type branch November 23, 2023 14:06
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 23, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 23, 2024
@WojciechMazur
Backport "Fix #19019: Always type self ValDefs in their outer context…
6eebcaf 
…." to LTS (#20764)

Backports #19030 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sjrd @odersky @Kordyjan