Fix java typer problems with inner class references and raw types #19747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sjrd
approved these changes
Feb 21, 2024
| @@ -34,7 +34,7 @@ object ContextOps: | |||
| if (elem.name == name) return elem.sym.denot // return self | |||
| } | |||
| val pre = ctx.owner.thisType | |||
| if ctx.isJava then javaFindMember(name, pre, required, excluded) | |||
| if ctx.isJava then javaFindMember(name, pre, lookInCompanion = true, required, excluded) | |||
There was a problem hiding this comment.
Why are we allowed to look in the companion here? This probably deserves a comment more than the false case.
tests/run/i19619/RawTypesGen.java
Outdated
|
|
||
| package lib; | ||
|
|
||
| public class RawTypesGen<W> { |
There was a problem hiding this comment.
This file is already not used in this commit, and it gets removed later. Consider removing it from this commit in the first place.
potential TODO: tree's of Raw types from Java are still incorrect once they are serialized to TASTy, however it is debateable if we care to support them.
bishabosha
force-pushed
the
tasty/fix-java-parse-issues
branch
from
df3273d
to
e8e295a
Compare
|
this was the error in CI: -- [E083] Type Error: tests/pos-java-interop-separate/inner-fbounds/Configurer_1.java:6:40 -----------------------------
6 | public final class Registry extends AbstractRegistry<Registry> {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
| AbstractConfigurer is not a valid class prefix, since it is not an immutable path
|
| longer explanation available when compiling with `-explain`this basically means that we can not widen the prefix of Java types, or you have to turn off the stability checker in Typer for Java types, or you only widen at Pickler. So I'll have to give up on preventing illegal types in Scala sources for java types like |
bishabosha
force-pushed
the
tasty/fix-java-parse-issues
branch
2 times, most recently
from
858b609
to
114f168
Compare
(If we widen Foo.this.Inner in the parents of a class to AbstractFoo#Inner, i.e. an inherited class Inner prefixed by its owner abstract class AbstractFoo, this is not considered a stable prefix for a class parent type. But in Java this is the correct type so allow it.)
bishabosha
force-pushed
the
tasty/fix-java-parse-issues
branch
from
114f168
to
d37857c
Compare
sjrd
approved these changes
Feb 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests changes against source dependency, Tasty dependency, and class dependency.
fixes #19619