Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Disallow ill-staged references to local classes #19869

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Disallow ill-staged references to local classes #19869

merged 1 commit into from
Mar 11, 2024

Conversation

nicolasstucki
Copy link
Contributor

Fixes #19856

@nicolasstucki nicolasstucki self-assigned this Mar 4, 2024
@nicolasstucki nicolasstucki marked this pull request as ready for review March 5, 2024 12:10
@nicolasstucki nicolasstucki requested a review from jchyb March 5, 2024 12:53
@nicolasstucki nicolasstucki assigned jchyb and unassigned nicolasstucki Mar 5, 2024
jchyb
jchyb approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@jchyb jchyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the late review

@nicolasstucki
Copy link
Contributor Author

Sorry for the late review

It was just under a week. Does not seem late to me :)

@nicolasstucki nicolasstucki merged commit f1e3dff into scala:main Mar 11, 2024
19 checks passed
@nicolasstucki nicolasstucki deleted the fix-19856 branch March 11, 2024 13:30
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 2, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 3, 2024
@WojciechMazur
Backport "Disallow ill-staged references to local classes" to LTS (#2…
7dc8d5e 
…0985)

Backports #19869 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jchyb jchyb jchyb approved these changes

Assignees

@jchyb jchyb

Labels
None yet
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.

Crash when referencing nested class in macro
3 participants
@nicolasstucki @jchyb @Kordyjan