Fix #19789: Merge same TypeParamRef in orDominator #20090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
reviewed
Apr 7, 2024
There was a problem hiding this comment.
I think this can be optimized by adding a first clause
if tp1 eq tp2 then tp1
Also, instead of comparing TypeParamRefs directly we could just do it like this:
case tp1: TypeParamRef if tp1 == tp2 => tp1
Note the first test might still need the second, since hash-consing is not 100% assured (e.g. we might get copies after a table overflow). So exploiting hash consing should always be an optimization only.
odersky
reviewed
Apr 8, 2024
odersky
approved these changes
Apr 10, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19789
Merge refined or applied types if they share the same
TypeParamRefas tycon inorDominator.