Fix #20146: attach the original name if there is an import selection for an indent #20163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noti0na1
changed the title
sjrd
requested changes
Apr 18, 2024
| val termSelections = sels.flatMap(n => qual.tpe.member(n.name.toTermName).alternatives) | ||
| val sameTermPath = qual.isTerm && sym.exists && sym.owner.isType && qual.tpe.typeSymbol == sym.owner.asType | ||
| val selectionsToDealias = typeSelections ::: termSelections | ||
| val renamedSelection = if sameTermPath then sels.find(sel => sel.imported.name == sym.name) else None |
There was a problem hiding this comment.
There is no equivalent to this line in the new code. Why did it disappear?
There was a problem hiding this comment.
renamedSelection is removed. As its name suggests, it tries to find renamed selections. However, I think this logic is redundant, because it just compare the names from sels with sym.name and ensure the path is valid, which will be done in selector later and has been ensured in typer.
sjrd
approved these changes
May 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20146
Attach the original name to the tree if there is an imported term selection for an indent.