Suppress "extension method will never be selected" for overrides #20164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In daeee35, support for tests in the directory `tests/pos-special/fatal-warnings` was dropped in favor of magic `//>` comments in the regular `tests/pos` directory, but a few tests were forgotten in the original directory and were thus not run. This commit moves them to the appropriate directory with the correct magic comment.
When we're overriding an existing extension method, we don't have the liberty of renaming the method, so we shouldn't get warnings we can't do anything about.
som-snytt
reviewed
Apr 11, 2024
| @@ -1,4 +1,4 @@ | |||
| //> using options -Wvalue-discard | |||
| //> using options -Xfatal-warnings -Wvalue-discard | |||
som-snytt
reviewed
Apr 11, 2024
| if !target.typeSymbol.denot.isAliasType && !target.typeSymbol.denot.isOpaqueAlias && hidden | ||
| then report.warning(ExtensionNullifiedByMember(sym, target.typeSymbol), sym.srcPos) | ||
| def checkExtensionMethods(sym: Symbol)(using Context): Unit = | ||
| if sym.is(Extension) && !sym.nextOverriddenSymbol.exists then |
|
This is like the mitigation for "unused param" which says that if my method signature is constrained by an override, don't warn. Here, I must supply the given (for some purpose), and I'm not interested in this extension. I could signal that with a LHS that is But probably this case has an odor of niche. Overriders of extensions probably know what they're doing. From the Doors song, |
som-snytt
approved these changes
Apr 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're overriding an existing extension method, we don't have the liberty
of renaming the method, so we shouldn't get warnings we can't do anything
about.